[LSP] phase 1 endpoints, dependency updates #18087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonie
approved these changes
Dec 2, 2024
This was
linked to
issues
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 1 endpoints
These were pretty much already there, just made sure they were also available for non-VS LSP. Added some basic tests.
Semantic tokens probably need some more work, but we have a separate issue for that: #17115 Also it will be easier to work on that once we can disable it in the old extension and can actually see what it does: #18067
Dependency updates
C# source packages are not great. They just dump all source files into the project. Which isn't very helpful in F# projects. So to include new CLASP version we now have
Microsoft.CommonLanguageServerProtocol.Framework.Proxyproject.Also at the moment using
NewtonsoftLanguageServer. Followup: #18068