highlight DU cases and Active Patterns as "Enum" Roslyn classification #1810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Ignore the AppVeyor failure, it's a timeout |
fix custom CE names and DU cases highlighting
vasily-kirichenko
force-pushed
the
pattern-colorizing
branch
from
04cc006 to
4b83070
Compare
Contributor
|
@vasily-kirichenko How does this compare to default VFPT colorization? thanks |
Contributor
Author
|
@dsyme by default VFPT highlights types, modules and quotations. So,I think it'd be ok to have types and modules highlighted in RTM, as a first step. The problem is than existing code has access to full ranges, which results with #1697 and fully.qualified.ctor.names are entirely colored in this PR. Also it's impossible to distinguish namespaces, which should not be colored, from modules. |
Contributor
Author
|
I'm closing it. See #1841 instead. |
Contributor
|
super, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
It looks like this:
Issues:
If this change is OK in principle, I can add highlighting for modules and, maybe, some other symbol kinds.