Skip to content

VS: show cache metrics in output pane when running a debug build vsix #18939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 2 commits into from
Sep 26, 2025
Merged

VS: show cache metrics in output pane when running a debug build vsix #18939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acbc02b
show cache metrics in output pane
majocha Sep 26, 2025
0be850b
format
majocha Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 17 additions & 18 deletions vsintegration/src/FSharp.Editor/Common/DebugHelpers.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ open Config
open System.Diagnostics.Metrics
open System.Text
open Microsoft.VisualStudio.Threading
open Microsoft.VisualStudio.FSharp.Editor.CancellableTasks

module FSharpOutputPane =

Expand All @@ -56,29 +57,17 @@ module FSharpOutputPane =
let private log logType msg =
task {
System.Diagnostics.Trace.TraceInformation(msg)
let time = DateTime.Now.ToString("hh:mm:ss tt")

let! pane = pane.GetValueAsync()

do! ThreadHelper.JoinableTaskFactory.SwitchToMainThreadAsync()

match logType with
| LogType.Message ->
String.Format("[{0}{1}] {2}{3}", "", time, msg, Environment.NewLine)
|> pane.OutputStringThreadSafe
|> ignore
| LogType.Info ->
String.Format("[{0}{1}] {2}{3}", "INFO ", time, msg, Environment.NewLine)
|> pane.OutputStringThreadSafe
|> ignore
| LogType.Warn ->
String.Format("[{0}{1}] {2}{3}", "WARN ", time, msg, Environment.NewLine)
|> pane.OutputStringThreadSafe
|> ignore
| LogType.Error ->
String.Format("[{0}{1}] {2}{3}", "ERROR ", time, msg, Environment.NewLine)
|> pane.OutputStringThreadSafe
|> ignore
| LogType.Message -> $"{msg}"
| LogType.Info -> $"[INFO] {msg}"
| LogType.Warn -> $"[WARN] {msg}"
| LogType.Error -> $"[ERROR] {msg}"
|> pane.OutputStringThreadSafe
|> ignore
}
|> ignore

Expand All @@ -102,6 +91,7 @@ module FSharpOutputPane =

module FSharpServiceTelemetry =
open FSharp.Compiler.Caches
open System.Threading.Tasks

let listen filter =
let indent (activity: Activity) =
Expand Down Expand Up @@ -130,6 +120,15 @@ module FSharpServiceTelemetry =

ActivitySource.AddActivityListener(listener)

let periodicallyDisplayCacheStats =
cancellableTask {
use _ = CacheMetrics.ListenToAll()

while true do
do! Task.Delay(TimeSpan.FromSeconds 10.0)
FSharpOutputPane.logMsg (CacheMetrics.StatsToString())
}

#if DEBUG
open OpenTelemetry.Resources
open OpenTelemetry.Trace
Expand Down
13 changes: 13 additions & 0 deletions vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,19 @@ type internal FSharpPackage() as this =
|> CancellableTask.startAsTask cancellationToken)
)

#if DEBUG
override _.RegisterOnAfterPackageLoadedAsyncWork(afterPackageLoadedTasks: PackageLoadTasks) =
afterPackageLoadedTasks.AddTask(
false,
fun _ _ ->
task {
DebugHelpers.FSharpServiceTelemetry.periodicallyDisplayCacheStats
|> CancellableTask.start this.DisposalToken
|> ignore
}
)
#endif

override _.RoslynLanguageName = FSharpConstants.FSharpLanguageName
(*override this.CreateWorkspace() = this.ComponentModel.GetService<VisualStudioWorkspaceImpl>() *)
override this.CreateLanguageService() = FSharpLanguageService(this)
Expand Down
Loading