Skip to content

More robust check for isSequential #2189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KevinRansom merged 3 commits into from
Jan 9, 2017
Merged

More robust check for isSequential #2189

KevinRansom merged 3 commits into from
Jan 9, 2017

Conversation

@liboz
Copy link
Contributor

@liboz liboz commented Jan 7, 2017

@forki This makes it so we use pattern matching instead of a ToString implementation to check if the Expr is Sequential or not.

forki
forki approved these changes Jan 8, 2017
View reviewed changes
Copy link
Contributor

@forki forki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@KevinRansom KevinRansom merged commit f8103bb into dotnet:master Jan 9, 2017
@liboz liboz mentioned this pull request Jan 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@forki forki forki approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liboz @forki @KevinRansom @msftclas