Implement ToString on Records (RFC FS-1022) #2430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Feb 13, 2017
src/fsharp/IlxGen.fs
Outdated
| yield mkILSimpleStorageCtor(None, Some cenv.g.ilg.typ_Object.TypeSpec, ilThisTy, [], reprAccess) | ||
|
|
||
|
|
||
| if (not <| tycon.HasMember cenv.g "ToString" []) then |
Contributor
There was a problem hiding this comment.
We generally don't use the backpipe operator in the compiler (except xyz <| (fun a -> ...) now and then)
dsyme
approved these changes
Feb 14, 2017
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Left one comment but basically this looks spot on
Contributor
|
@liboz Please test struct records, thanks |
liboz
changed the title
KevinRansom
approved these changes
Feb 15, 2017
Contributor
|
Nice ... Thank you |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends #1589 to Record types and is an implementation of RFC FS-1022
Still need to fix tests.