Skip to content

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented Nov 7, 2017

Applies all of the patches from the dotnet/source-build repo here.

Status of all patches:

  1. Fix buildfromsource.sh when run from outside src: previously applied, no change.
  2. Add NuGet.config: added src\buildfromsource\NuGet.config instead of adding one at the repo root.
  3. Allow overriding BuildRevision: patch directly applied.
  4. Fix casing: patch directly applied.
  5. Use versions of SymReader we are building: previously applied, no change.
  6. Add RC to prerelease tag: patch directly applied.
  7. Don't restore FSharp.Core nupkg, use source: created src/buildfromsource-specific copies of fslex.fsproj and fsyacc.fsproj with the necessary changes.
  8. Fix copy targets to nupkg: patch directly applied.
  9. Add resx files...: copied in appropriate .resx files as well as the source previously generated by the <FsSrGen> build task. This enabled removal of the <FsSrgen> handling alltogether.

Once this PR is merged the next step will be to update the dotnet/source-build repo to remove the F# patches and update the submodule pointer.

@KevinRansom KevinRansom merged commit 433b331 into dotnet:master Nov 8, 2017
@brettfo brettfo deleted the patches branch November 8, 2017 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants