Remove a setify + isSingleton combo #4980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
force-pushed
the
setify4
branch
3 times, most recently
from
e9e5f76 to
49d3db9
Compare
dsyme
approved these changes
May 23, 2018
src/fsharp/TypeChecker.fs
Outdated
Contributor
There was a problem hiding this comment.
I prefer the original code on this line (but it's not big deal either way)
Contributor
Author
There was a problem hiding this comment.
Actually I only touched it to show we checked that case. Now I can revert it ;-)
Contributor
|
@forki will you revert the change, or are you okay with this PR as is? |
Contributor
Author
|
@KevinRansom reverted that line. this is ready now. |
Contributor
|
@forki thanks mate. |
KevinRansom
pushed a commit
that referenced
this pull request
May 24, 2018
* Fixing #4967 (#4968) * Fix internal error when compiling interface implementation lacking an overloaded method implementation - fixes #4967 * Adding a test * Update E_OverloadMismatch.fs * Remove a setify + isSingleton combo (#4980) * remove a setify * Remove intermediate collection * Improve async stack traces (#4867) * very early prototype * async stack traces * async cleanup * minor fix * async cleanup * more async cleanup * integrate async-cleanup * async cleanup * fix build * more cleanup * minor fixes * minor fixes * full exception stacktraces * fix test * fix test * code review * cleanup naming * fix build * undo rethrow and integrate cleanup * apply renamings * Further cleanup in control.fs * add tests and add filtering TryWith, plus other cleanup * integrate cleanup * fix tests * test only runs on .net framework * slightly tweak primitives to be more suitable for later optimization * slightly tweak primitives to be more suitable for later optimization * update baselines * add check that no line 0 appear in stack * update baseline * use struct wrapper for async activation * simplify code * simplify code * update baselines * update baselines * fix baseline * remove dead code * simplify code * apply DebuggerHidden in a couple more places * [ RFC FS-1039] implementation of value options (#4837) * posible implementation of value options * fix surface area test * fix test * VNone --> ValueNone * fix surface area * fix build * update baselines * fix baselines * fix baselines * fix baselines * fix baselines * fix build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.