Skip to content

Provide fast generic comparer for bool values #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 3 commits into from
Jun 4, 2018
Merged

Provide fast generic comparer for bool values #5076

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03e0189
provide fast generic comparer for bool values
vasily-kirichenko Jun 2, 2018
0e26191
Merge remote-tracking branch 'origin/master' into fast-bool-comparer
vasily-kirichenko Jun 3, 2018
1160fa4
formatting
vasily-kirichenko Jun 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/fsharp/FSharp.Core/prim-types.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,6 +2162,7 @@ namespace Microsoft.FSharp.Core
let FloatComparer = MakeGenericComparer<float>()
let Float32Comparer = MakeGenericComparer<float32>()
let DecimalComparer = MakeGenericComparer<decimal>()
let BoolComparer = MakeGenericComparer<bool>()

/// Use a type-indexed table to ensure we only create a single FastStructuralComparison function
/// for each type
Expand Down Expand Up @@ -2199,6 +2200,7 @@ namespace Microsoft.FSharp.Core
| ty when ty.Equals(typeof<float32>) -> null
| ty when ty.Equals(typeof<decimal>) -> null
| ty when ty.Equals(typeof<string>) -> unboxPrim (box StringComparer)
| ty when ty.Equals(typeof<bool>) -> null
| _ -> MakeGenericComparer<'T>()

static let f : System.Collections.Generic.IComparer<'T> =
Expand All @@ -2218,6 +2220,7 @@ namespace Microsoft.FSharp.Core
| ty when ty.Equals(typeof<float32>) -> unboxPrim (box Float32Comparer)
| ty when ty.Equals(typeof<decimal>) -> unboxPrim (box DecimalComparer)
| ty when ty.Equals(typeof<string>) -> unboxPrim (box StringComparer)
| ty when ty.Equals(typeof<bool>) -> unboxPrim (box BoolComparer)
| _ ->
// Review: There are situations where we should be able
// to return System.Collections.Generic.Comparer<'T>.Default here.
Expand Down