add "Other Tips" notes to TESTGUIDE.md and a script to update baseline files under test/fsharp #5117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rework "Other Tips" section to expand on the system of baselines files used in FSharp Test Suite
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
dsyme
reviewed
Jun 6, 2018
| ] | ||
| |> List.map (fun d -> Path.Combine(__SOURCE_DIRECTORY__, d) |> DirectoryInfo) | ||
|
|
||
| let extensionPatterns = ["*.err"; "*.vserr"] |
Contributor
There was a problem hiding this comment.
You should also move *.il --> *.il.bsl under fsharpqa\Source, e.g.
Contributor
There was a problem hiding this comment.
Make it a single script under tests\scripts?
Contributor
|
This is good, just the one adjustment requested |
Contributor
|
@smoothdeveloper I'll make the change as I need to update some |
Contributor
Author
|
Thanks, great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to make contributions easier to test/fsharp
changes: