Skip to content

Fix sbyte arrays comparison #5267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vasily-kirichenko wants to merge 2 commits into from
Closed

Fix sbyte arrays comparison #5267

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aa79ce
fix sbyte arrays comparison
vasily-kirichenko Jun 30, 2018
e11bfdc
Merge remote-tracking branch 'origin/master' into fix-sbyte-arrays-co…
vasily-kirichenko Jun 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/fsharp/FSharp.Core/prim-types.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,8 +834,8 @@ namespace Microsoft.FSharp.Core
match arr1,yobj with
// Fast path
| (:? (obj[]) as arr1), (:? (obj[]) as arr2) -> GenericComparisonObjArrayWithComparer comp arr1 arr2
// Fast path
| (:? (byte[]) as arr1), (:? (byte[]) as arr2) -> GenericComparisonByteArray arr1 arr2
// Fast path. We cannot use `:? byte[]` because this would match both byte and sbyte arrays.
| _ when xobj.GetType().Equals typedefof<byte[]> && yobj.GetType().Equals typedefof<byte[]> -> GenericComparisonByteArray (xobj :?> byte[]) (yobj :?> byte[])
| _ , (:? System.Array as arr2) -> GenericComparisonArbArrayWithComparer comp arr1 arr2
| _ -> FailGenericComparison xobj
// Check for IStructuralComparable
Expand Down