Empty shortcuts #5370
Merged
Empty shortcuts #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
approved these changes
Aug 9, 2018
KevinRansom
suggested changes
Aug 9, 2018
|
|
||
| [<CompiledName("DistinctBy")>] | ||
| let distinctBy projection (array:'T[]) = | ||
| let length = array.Length |
Contributor
There was a problem hiding this comment.
@forki --- Null check here: Using array without verifying if it is not null.
Contributor
Author
There was a problem hiding this comment.
just looked it up - the null check is already in outer function
Contributor
There was a problem hiding this comment.
I believe it's a public API, I'm pretty sure a null check is required,
Contributor
There was a problem hiding this comment.
Yes, this is a public API. Prior to this change the null check was the first line to this function.
Contributor
Author
There was a problem hiding this comment.
oh was looking on the wrong one
Contributor
Author
|
Looks like we are missing a test then. I'll add both.
Kevin Ransom (msft) <notifications@github.com> schrieb am Do., 9. Aug.
2018, 20:35:
… ***@***.**** requested changes on this pull request.
------------------------------
In src/fsharp/FSharp.Core/array.fs
<#5370 (comment)>
:
> @@ -278,6 +281,9 @@ namespace Microsoft.FSharp.Collections
[<CompiledName("DistinctBy")>]
let distinctBy projection (array:'T[]) =
+ let length = array.Length
@forki <https://github.com/forki> --- Null check here: Using array
without verifying if it is not null.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5370 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADgNOOWGRZgsTLgGjAnJrHmcq7dyr20ks5uPID9gaJpZM4Vanrl>
.
|
KevinRansom
reviewed
Aug 10, 2018
Contributor
|
The VSTS: public -CI is the gatekeeper now. Fails on ci_part2 and ci_part3. From ci_part2: From ci_part3 |
KevinRansom
approved these changes
Aug 12, 2018
Contributor
|
@forki |
Contributor
|
@KevinRansom As mentioned in #5942 this is an incorrect optimization. We should revert and publish a new version of FSharp.Core assuming this has made it out into the wild (I think it has) Please lets be ultra careful in this in the future... |
Contributor
|
That is the Seq cases are incorrect |
KevinRansom
pushed a commit
that referenced
this pull request
Nov 26, 2018
* Fix and tests, unbuilt and untested * Correct one of the tests Got the order wrong for the output of `countBy`. * Repair the groupBy test groupBy test was bad: it assumed (ridiculously) that groupBy wouldn't iterate the original sequence even though it somehow knew the groups in the sequence.
KevinRansom
pushed a commit
to KevinRansom/fsharp
that referenced
this pull request
Nov 26, 2018
… (dotnet#5947) * Fix and tests, unbuilt and untested * Correct one of the tests Got the order wrong for the output of `countBy`. * Repair the groupBy test groupBy test was bad: it assumed (ridiculously) that groupBy wouldn't iterate the original sequence even though it somehow knew the groups in the sequence.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more shortcuts in style of #5348