Skip to content

Navigation Menu

Appearance settings

View all features
- BY COMPANY SIZE
  Enterprises
  Small and medium teams
  Startups
  Nonprofits
- BY USE CASE
  App Modernization
  DevSecOps
  DevOps
  CI/CD
  View all use cases
- BY INDUSTRY
  Healthcare
  Financial services
  Manufacturing
  Government
  View all industries
View all solutions
- EXPLORE BY TOPIC
  AI
  Software Development
  DevOps
  Security
  View all topics
- EXPLORE BY TYPE
  Customer stories
  Events & webinars
  Ebooks & reports
  Business insights
  GitHub Skills
- SUPPORT & SERVICES
  Documentation
  Customer support
  Community forum
  Trust center
  Partners
- COMMUNITY
  GitHub SponsorsFund open source developers
- PROGRAMS
  Security Lab
  Maintainer Community
  Accelerator
  Archive Program
- REPOSITORIES
  Topics
  Trending
  Collections
- ENTERPRISE SOLUTIONS
  Enterprise platformAI-powered developer platform
- AVAILABLE ADD-ONS
  GitHub Advanced SecurityEnterprise-grade security features
  Copilot for BusinessEnterprise-grade AI features
  Premium SupportEnterprise-grade 24/7 support
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

Appearance settings

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

dotnet / fsharp Public

Notifications You must be signed in to change notification settings
Fork 847
Star 4.2k

Code
Issues 1.3k
Pull requests 73
Discussions
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Discussions
Actions
Projects
Security
Insights

[CompilerPerf] Removed TaggedCollections from Compiler#5463

Closed

manofstick wants to merge 92 commits intodotnet:masterdotnet/fsharp:masterfrom

manofstick:notaggedmanofstick/visualfsharp:notaggedCopy head branch name to clipboard

Conversation Commits92 (92)Checks Files changed

Closed

[CompilerPerf] Removed TaggedCollections from Compiler#5463
manofstick wants to merge 92 commits intodotnet:masterfrom
manofstick:notagged

Commits

Commits on Aug 12, 2018

Helper function for FastGenericEqualityComparerTable
manofstick
committed
Use the default equality comparer where applicable
manofstick
committed
Avoid calls to GenericEqualityObj for known types
manofstick
committed
Avoid boxing in the "standard" use of GenericEqualityWithComparerIntrinsic
manofstick
committed
Added method to avoid tail calls
manofstick
committed
Implemented hashing
manofstick
committed
Additional use of EqualityComparer.Default
manofstick
committed
Consistent naming
manofstick
committed
Fixed up by mix up my ERs with my PERs!
manofstick
committed
Apply De Morgan's law to make it a bit cleaner
manofstick
committed
Argh, got the PER and ER mixed up even when I tried to fix. Now good (hopefully!)
manofstick
committed
Removed custom delegates by using System.Func
manofstick
committed
Disallow optimization on Nullable types
manofstick
committed
More inclusive check for canUseDefaultEqualityComparer
manofstick
committed
Updated il output files
manofstick
committed
Removed IERorPER by splitting calling class into 2, and added helper functions
manofstick
committed
Changed it all to used EqualityComparer derived classes and restored tail calls
manofstick
committed
Removed comparers that matched EqualityComparer<>.Default and code review changes
manofstick
committed
Added additional types where EqualityComparer.Default can be used
manofstick
committed
Save unnecessary type checks when more information is known
manofstick
committed
Removed now unused objects, and other minor cleanup
manofstick
committed
Modified Optimizer to manually inline GenericEqualityIntrinsic and friends (as they have special handling)
manofstick
committed
Fixed SurfaceArea
manofstick
committed
Ensure FSharp.Core has the optimization functions (and added comments)
manofstick
committed
Remove IL bloat from this PR as per https://github.com/Microsoft/visualfsharp/issues/5212
manofstick
committed
Remove null checks for IStructuralEquality Value Types
manofstick
committed
Consolidated Type Specific Array Equality functions
manofstick
committed
Fix compiler call via FSharpFunc.Invoke rather than direct
manofstick
committed
Replaced duplicated GetHashCode code with inline function
manofstick
committed
Common array EqualityComparers (for types that previously had specialized GetHashCode)
manofstick
committed
Fix regression in regards to hash code on fast-path covariant arrays (+ comments)
manofstick
committed
Similar treatment within prim-types for Comparer as #5112 was for EqualityComparer
manofstick
committed
Moved throwing exceptions closer
manofstick
committed
Added comparison usage, so could remove exception catching logic when unnecessary
manofstick
committed
Consolidated functions
manofstick
committed
Consolidated ArrayComparisons and addressed issue #5263
manofstick
committed
Fixed bug introduced in #5278 where an unstable sort could be used where a stable one was required
manofstick
committed
Removed now unnecessary optimization from stableSortWithKeysAndComparer
manofstick
committed
Moved isRecordType down to prim-types.fs (internal only)
manofstick
committed
Moved enough of reflect.fs to get Record fields
manofstick
committed
Moved reflection functions for Union types into prim-types.fs
manofstick
committed
Removed methods from prim-types.fsi that are now just used internally
manofstick
committed
Used the reflection functions to handle records and unions
manofstick
committed
Added check for fsharp value types
manofstick
committed
Fixed struct check where a [<DefaultValue>] field is used.
manofstick
committed
Minor shift in logic order for less comparisons
manofstick
committed
Removed MapOne case for performance.
manofstick
committed
Converted Map.Count from O(n) to O(1)
manofstick
committed
inlined mk/mkLeaf
manofstick
committed
optimize ofSeq, ofList, ofArray via a temporary sorted ResizeArray and direct tree construction
manofstick
committed
Split rebalance so as to inline decision logic
manofstick
committed
Removed MapEmpty
manofstick
committed
manual selective inlining of rebalance in add
manofstick
committed
Only access members when necessary - measurable performance diff for find's inner loop
manofstick
committed
Consolidated find functionality
manofstick
committed
Labelled MapNode fields
manofstick
committed
Revamped enumeration to create less garbage. Faster on 64-bit, slower on 32-bit.
manofstick
committed
Added Checked logic to ensure size constraint isn't violated
manofstick
committed
findImpl use helper functions to clean up
manofstick
committed
Made the non-(to|of)(Seq|List|Array) Map changes to the TaggedCollections version
manofstick
committed
Removed SetOne
manofstick
committed
Converted Set's height to size
manofstick
committed
Cut SetTree down to just SetNode
manofstick
committed
rebalance split and add from Map
manofstick
committed
Easy case Zmap to Map
manofstick
committed
Removed IntMap
manofstick
committed
Added SortKey as Adapter for Map to use IComparable
manofstick
committed
Converted Zmaps on Val types
manofstick
committed
...working way through all Zmaps...
manofstick
committed
Fixed call missed in #debug section
manofstick
committed
Removed remaining usages of Zmap
manofstick
committed
Removed now unused TaggedCollections.Map & Zmap
manofstick
committed
Converted Map.force to MapCustom.force
manofstick
committed
Renamed MapCusom to Zmap
manofstick
committed
Type alias : zmap<...> = Map<SortKey<...>...>
manofstick
committed
Created SetCustom to remove Zset
manofstick
committed
mhiVals to SetCustom
manofstick
committed
converted all zset<Val>s
manofstick
committed
Transferred Zset<Typar> to SetCustom
manofstick
committed
Tycon set conversion
manofstick
committed
Final two Zset orderers converted
manofstick
committed
Added NoComparison/NoEquality to ordering objects
manofstick
committed
Changed dontInline to normal set
manofstick
committed
Replacing Zset usage where plain Set could be used
manofstick
committed
Removed few remaining usages of Zset
manofstick
committed
Deleted zset and TaggedCollections
manofstick
committed
Renamed comparers to be based off original names
manofstick
committed
Renamed SetCustom to Zset
manofstick
committed
Brought Zmap naming inline with Map
manofstick
committed

Commits on Aug 13, 2018

Revert "Deleted zset and TaggedCollections"
manofstick
committed
Removing zset & taggedcollections
manofstick
committed
Removed unused commented code
manofstick
committed

Footer

© 2026 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Community
Docs
Contact

You can’t perform that action at this time.