Remove dependence on runfsc.cmd and runfsc.sh #5882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why aren't the scripts deleted? |
Contributor
Author
|
@nguerrera --- The scripts are deployed from the net cli here: https://github.com/dotnet/cli/tree/release/2.2.2xx/src/tool_fsharp When we insert the F# package into dotnet cli, we will updtae the project, and delete them at that time. Kevin |
brettfo
approved these changes
Nov 12, 2018
KevinRansom
force-pushed
the
removefsccmd
branch
from
1bfdc85 to
6cf61e0
Compare
KevinRansom
pushed a commit
that referenced
this pull request
Nov 13, 2018
* Remove dependence on runfsc.cmd and runfsc.sh (#5882) * Remove dependence on runfsc.cmd and runfsc.sh * White space * Add TryExactlyOne for array, list and seq. (#5804) * FS-1065 Value Option Parity (#5772) * Initial FS-1065 implementation * Undo removal of compilationrepresentation suffix and update surface area * Whoopise, add the suffix to the impl file * Update coreclr surface area * Revert the FSComp changes that somehow got picked up * newline * Consume internal VOption module functions * More internal voption module functions
wli3
pushed a commit
to wli3/core-sdk
that referenced
this pull request
Feb 11, 2019
Per dotnet/fsharp#5882 This file is no longer needed and removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dotnet cli uses RunFsc.cmd and RunFsc.sh to execute the FSharp command in the build task using a single command.
There is an issue with this on those rare Linux packagings that don't have a bash shell configured.
This change, modifies the way the fsharp build task executes the fsharp compiler.
We now use the DotnetFscCompilerPath property to be the path to the F# compiler executable.
FscToolPath and FSCToolExe now point to the dotnet.exe specified in the guaranteed global property DOTNET_HOST_PATH.
What's nice about this, is that no sdk changes are necessary.