Add new implementation of IEnumerable<_> for dict #5918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
approved these changes
Nov 17, 2018
| let kvps = [| for (KeyValue (k,v)) in t -> KeyValuePair (getKey k, v) |] :> seq<_> | ||
| kvps.GetEnumerator() | ||
| #else | ||
| let endIndex = t.Count |
Member
There was a problem hiding this comment.
I'd prefer this be called count since that's how it's used, but this isn't a hill I'm going to die on.
Contributor
Author
There was a problem hiding this comment.
@brettfo endindex is the name for that value in the original bcl source code. I too chuckled over the ridiculousness of the name.
dsyme
approved these changes
Nov 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5910
The coreclr has a bug with SZGenericArrayEnumerators. The bug causes it to not throw when accessing Current for an exhausted collection. The Coreclr team will fix this bug, however.
This PR introduces a correctly operating enumerator where we have a dependence on SZGenericArrayEnumerator.
We missed this in testing because we use an old version of the coreclr which doesn't have the bug.
This PR, continues to use the framework implementation on FSharp.Core.dll built for the NETFramework, because that code is correct and ngened in all scenarios.