Do not get the absolute value of Map's hash code #6072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #6068, where you could cause a `System.OverFlowException` by using a key and value that leads to calling `abs` on `Int32.MinValue`. This is invalid on .NET. The fix is to not call `abs`, since there's really no reason to make a hash code always positive.
dsyme
reviewed
Jan 11, 2019
| member this.ComputeHashCode() = | ||
| let combineHash x y = (x <<< 1) + y + 631 | ||
| let mutable res = 0 | ||
| for (KeyValue(x,y)) in this do |
Contributor
There was a problem hiding this comment.
The iteration here could be improved, it currently allocates. We could pass a byref through a recursive helper function, would be faster. Not critical for this PR though.
dsyme
approved these changes
Jan 11, 2019
KevinRansom
approved these changes
Jan 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6068, where you could cause a
System.OverFlowExceptionby using a key and value that leads to callingabsonInt32.MinValue. This is invalid on .NET. The fix is to not callabs, since there's really no reason to make a hash code always positive.