Skip to content

Enable Langversion to control relaxwhitespace language feature#6933

Merged
KevinRansom merged 2 commits intodotnet:release/fsharp47from
KevinRansom:langversion4relaxwhitespace
Jun 4, 2019
Merged

Enable Langversion to control relaxwhitespace language feature#6933
KevinRansom merged 2 commits intodotnet:release/fsharp47from
KevinRansom:langversion4relaxwhitespace

Conversation

@KevinRansom
Copy link
Copy Markdown
Contributor

These are getting easier now.

Controls the whitespace relaxation language change.

again the bulk of this PR exists already in the unmerged pr: #6891
The only part worth looking at is this commit: 7f0bdb7

It adds, feature flags, the feature enabling modification
and moves the neg tests to versioning tests

C:\temp\ws>c:\kevinransom\fsharp\artifacts\bin\fsc\Release\net472\fsc Program.fs
Microsoft (R) F# Compiler version 10.6.0.0 for F# 4.7
Copyright (c) Microsoft Corporation. All Rights Reserved.

Program.fs(6,9): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (5:19). Try indenting this token further or using standard formatting conventions.

Program.fs(6,9): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (5:19). Try indenting this token further or using standard formatting conventions.

Program.fs(11,9): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (10:21). Try indenting this token further or using standard formatting conventions.

Program.fs(11,9): warning FS0058: Possible incorrect indentation: this token is offside of context started at position (10:21). Try indenting this token further or using standard formatting conventions.

C:\temp\ws>c:\kevinransom\fsharp\artifacts\bin\fsc\Release\net472\fsc --langversion:preview Program.fs
Microsoft (R) F# Compiler version 10.6.0.0 for F# 4.7
Copyright (c) Microsoft Corporation. All Rights Reserved.

C:\temp\ws>

@KevinRansom KevinRansom force-pushed the langversion4relaxwhitespace branch from 7f0bdb7 to d175162 Compare June 3, 2019 09:31
@KevinRansom KevinRansom requested a review from brettfo June 3, 2019 17:25
@KevinRansom KevinRansom force-pushed the langversion4relaxwhitespace branch from d175162 to 9931ab3 Compare June 3, 2019 20:42
@KevinRansom KevinRansom merged commit af9145b into dotnet:release/fsharp47 Jun 4, 2019
@KevinRansom KevinRansom deleted the langversion4relaxwhitespace branch July 2, 2019 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants