#6928 - Removed SByte and Byte from default case requirement and added check for complete match.#7445
Merged
cartermp merged 2 commits intodotnet:masterfrom Aug 29, 2019
Conversation
…d added check for complete match.
cartermp
approved these changes
Aug 24, 2019
Contributor
|
That was easier to fix than I realized :) |
Contributor
|
Thanks @gdziadkiewicz! |
gdziadkiewicz
deleted the
feature/Exhaustive_pattern_matches_on_numeric_values_yield_compiler_warning_#6928
branch
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
…d added check for complete match. (dotnet#7445) * dotnet#6928 - Removed SByte and Byte from default case requirement and added check for complete match. * Upgrade new tests (dotnet#6928)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #6928