Fix native resource issue with empty streams#7461
Merged
KevinRansom merged 2 commits intodotnet:masterfrom Aug 29, 2019
Merged
Conversation
cartermp
reviewed
Aug 29, 2019
cartermp
approved these changes
Aug 29, 2019
Co-Authored-By: Phillip Carter <pcarter@fastmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on something I discovered that native resource streams can be empty.
This PR adds a check so that native resource embedding doesn't fail when it is empty.
The change is one line plus an iddy biddy little comment, so best review the code with ?w=1