[re-merge] [RFC FS-1046] Wildcard self identifier. Allow single underscore in members#7634
Closed
brettfo wants to merge 1 commit intodotnet:masterfrom
Closed
[re-merge] [RFC FS-1046] Wildcard self identifier. Allow single underscore in members#7634brettfo wants to merge 1 commit intodotnet:masterfrom
brettfo wants to merge 1 commit intodotnet:masterfrom
Conversation
…mbers. (dotnet#6829) * Add Underscore Dot rule * Update tests * Revert line where x is used * Code fix rename to single underscore
cartermp
approved these changes
Sep 26, 2019
Member
Author
|
I just spoke with @KevinRansom and we remembered that the changes in this cherry-pick were explicitly reverted in favor of adding specific tests in tests/fsharp/core/members/self-identifier/version47/test.fs. Therefore this will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow #6829 was lost in the merge ether, so this is a cherry-pick to bring it back to
master.Hopefully this will unblock #7631.