Voption tostring and other stuff#7712
Merged
KevinRansom merged 9 commits intodotnet:masterfrom Oct 30, 2019
cartermp:voption-tostring
Merged
Voption tostring and other stuff#7712KevinRansom merged 9 commits intodotnet:masterfrom cartermp:voption-tostring
KevinRansom merged 9 commits intodotnet:masterfrom
cartermp:voption-tostring
Conversation
auduchinok
reviewed
Oct 8, 2019
Co-Authored-By: Eugene Auduchinok <eugene.auduchinok@gmail.com>
…fsharp into voption-tostring
Contributor
Author
|
I bet it's some goddamn baselines again |
dsyme
approved these changes
Oct 9, 2019
abelbraaksma
suggested changes
Oct 12, 2019
tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Core/OptionModule.fs
Show resolved
Hide resolved
KevinRansom
approved these changes
Oct 30, 2019
5 tasks
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Fix some issues in ValueNone implementation * More debug display * Some for options in debug display * Apply suggestions from code review Co-Authored-By: Eugene Auduchinok <eugene.auduchinok@gmail.com> * Probably better stringing * Add them baselines * Add sprintfn tests * Update OptionModule.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7693
Also adjusts how we do debugger display for options and voptions