Skip to content

Be very literal about the LangVersion string#7895

Merged
cartermp merged 2 commits intodotnet:masterfrom
cartermp:langversion-no-culture
Nov 22, 2019
Merged

Be very literal about the LangVersion string#7895
cartermp merged 2 commits intodotnet:masterfrom
cartermp:langversion-no-culture

Conversation

@cartermp
Copy link
Copy Markdown
Contributor

@cartermp cartermp commented Nov 21, 2019 •
edited
Loading

fixes #7757

@cartermp
Copy link
Copy Markdown
Contributor Author

cartermp commented Nov 21, 2019

@brettfo

X Evaluation can be cancelled [10s 724ms]
  Error Message:
     Expected: less than or equal to 10000
  But was:  10215

?

at FSharp.Compiler.Scripting.UnitTests.InteractiveTests.Evaluation can be cancelled() in D:\a\1\s\tests\FSharp.Compiler.Private.Scripting.UnitTests\FSharpScriptTests.fs:line 105

@cartermp cartermp requested a review from KevinRansom November 22, 2019 00:21
@cartermp cartermp merged commit 7780047 into dotnet:master Nov 22, 2019
@0x53A 0x53A mentioned this pull request Apr 22, 2020
Closed
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@cartermp @nosami
Be very literal about the LangVersion string (dotnet#7895)
9d0f808 
* Be very literal about the LangVersion string

* Skip timing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@brettfo brettfo brettfo approved these changes

@KevinRansom KevinRansom KevinRansom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--langversion parser is culture-dependent

3 participants

@cartermp @brettfo @KevinRansom