Fixed type abbreviation from bypassing ByRefLike rules#7953
Merged
cartermp merged 6 commits intodotnet:masterfrom Dec 16, 2019
Merged
Fixed type abbreviation from bypassing ByRefLike rules#7953cartermp merged 6 commits intodotnet:masterfrom
cartermp merged 6 commits intodotnet:masterfrom
Conversation
Contributor
cartermp
approved these changes
Dec 11, 2019
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Looks good but I think the test names should be different
1 task
I like @cartermps test name changes. Co-Authored-By: Phillip Carter <pcarter@fastmail.com>
KevinRansom
approved these changes
Dec 15, 2019
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
* Trying to fix span type abbrev * Fixed type abbrev issue on span * Fixing build * Update test * Apply suggestions from code review I like @cartermps test name changes. Co-Authored-By: Phillip Carter <pcarter@fastmail.com> * Update PostInferenceChecks.fs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a simple fix. Resolves #6133 and #6133. Looks like this PR: #6135 was intended to do the same thing too.