Fix expr tests to work on debug#8011
Merged
KevinRansom merged 1 commit intodotnet:masterfrom Dec 18, 2019
Merged
Conversation
cartermp
approved these changes
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whilst working on #7968, I realized that I was seeing test failures on vs-integration unit tests on Debug builds.
The debug and release compiler seem to optimize differently, causing these tests to fail on debug. I have seen these failures on debug before, so I believe this difference is long standing behavior.
We could consider an issue that would fix this build flavor distinction. But the purpose of this PR, is to ensure that running these tests under debug do not fail.