Skip to content

Fixed exception that prevented creating a memory mapped file that shadow copies a file on-disk #8238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 2 commits into from
Jan 17, 2020
Merged

Fixed exception that prevented creating a memory mapped file that shadow copies a file on-disk #8238

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9b3d7c
Fixed exception that prevented creating a memory mapped file that is …
TIHan Jan 16, 2020
51415b4
Update bytes.fs
TIHan Jan 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/absil/bytes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,10 +306,11 @@ type ByteMemory with
leaveOpen=false)
mmf, mmf.CreateViewAccessor(0L, length, memoryMappedFileAccess), length

// Validate MMF with the access that was intended.
match access with
| FileAccess.Read when not accessor.CanRead -> failwith "Cannot read file"
| FileAccess.Write when not accessor.CanWrite -> failwith "Cannot write file"
| _ when not accessor.CanRead || not accessor.CanWrite -> failwith "Cannot read or write file"
| FileAccess.Read when not accessor.CanRead -> invalidOp "Cannot read file"
| FileAccess.Write when not accessor.CanWrite -> invalidOp "Cannot write file"
| FileAccess.ReadWrite when not accessor.CanRead || not accessor.CanWrite -> invalidOp "Cannot read or write file"
| _ -> ()

let safeHolder =
Expand Down