Skip to content

Allow length of zero for ByteMemory #8273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 1 commit into from
Jan 19, 2020
Merged

Allow length of zero for ByteMemory #8273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/absil/bytes.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ type ByteArrayMemory(bytes: byte[], offset, length) =
inherit ByteMemory()

do
if length <= 0 || length > bytes.Length then
if length < 0 || length > bytes.Length then
raise (ArgumentOutOfRangeException("length"))

if offset < 0 || (offset + length) > bytes.Length then
Expand Down Expand Up @@ -155,7 +155,7 @@ type RawByteMemory(addr: nativeptr<byte>, length: int, hold: obj) =
raise (ArgumentOutOfRangeException("i"))

do
if length <= 0 then
if length < 0 then
raise (ArgumentOutOfRangeException("length"))

override _.Item
Expand Down