-
Notifications
You must be signed in to change notification settings - Fork 847
[WIP] Test cases and minor fixes for "Fix inlining on subtypes" #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @mpetruska, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
|
@mpetruska, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@mpetruska we will likely get to look at this in the new year but it sure was a great present, thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely sure that this only happens when valu (at line 2749) is set to UnknownValue,
|
@mpetruska in your opinion is this PR ready to pull? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this change for and which test case covers it?
|
Marking WIP until the questions above are answered |
|
I think we can close this since there's been no action for quite a while. I'm not sure what additional cases are being covered here |
This PR contains a test case and adds some minor fixes for PR #763, which contains the fix for issues #614 and #740 .