Skip to content

Conversation

@mpetruska
Copy link
Contributor

This PR contains a test case and adds some minor fixes for PR #763, which contains the fix for issues #614 and #740 .

@msftclas
Copy link

Hi @mpetruska, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas
Copy link

@mpetruska, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

@KevinRansom
Copy link
Contributor

@mpetruska we will likely get to look at this in the new year but it sure was a great present, thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure that this only happens when valu (at line 2749) is set to UnknownValue,

@KevinRansom
Copy link
Contributor

@mpetruska in your opinion is this PR ready to pull?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this change for and which test case covers it?

@dsyme
Copy link
Contributor

dsyme commented Jan 27, 2016

Marking WIP until the questions above are answered

@dsyme dsyme changed the title Fix inlining on subtypes - test cases, minor fixes [WIP] Fix inlining on subtypes - test cases, minor fixes Jan 27, 2016
@dsyme dsyme changed the title [WIP] Fix inlining on subtypes - test cases, minor fixes [WIP] Test cases and minor fixes for "Fix inlining on subtypes" Jan 27, 2016
@dsyme
Copy link
Contributor

dsyme commented Mar 2, 2016

I think we can close this since there's been no action for quite a while. I'm not sure what additional cases are being covered here

@dsyme dsyme closed this Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants