Fix for some 3180 warnings #841
Conversation
|
Hi @mpetruska, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -35,12 +35,12 @@ open Microsoft.FSharp.Core.CompilerServices | |||
| /// Unique name generator for stamps attached to lambdas and object expressions | |||
| type Unique = int64 | |||
| //++GLOBAL MUTABLE STATE | |||
| let newUnique = let mutable i = 0L in fun () -> System.Threading.Interlocked.Increment(&i) | |||
| let newUnique = let i = ref 0L in fun () -> System.Threading.Interlocked.Increment(i) | |||
There was a problem hiding this comment.
Mutable is ok, ref also ( there is an old school fan club 😄 )
Maybe there is safer to use ref than remove the warning
👍 for @mpetruska
There was a problem hiding this comment.
Thanks, my thoughts exactly. Not too experienced with the build system yet, so I'd rather modify code than build parameters.
|
This can be merged. I'm Ok with making all allocations explicit in the compiler. |
|
@KevinRansom can you check and merge this? the debug build doesnt compile atm |
|
I'll merge this (as I need the debug build in any case) |
|
really thx @dsyme |
4 participants
This tiny PR contains the fix for issue #840.