Skip to content

Fix wild self id pat range#8635

Merged
cartermp merged 1 commit intodotnet:masterfrom
auduchinok:member-wildSelfId-range
Feb 28, 2020
Merged

Fix wild self id pat range#8635
cartermp merged 1 commit intodotnet:masterfrom
auduchinok:member-wildSelfId-range

Conversation

@auduchinok
Copy link
Copy Markdown
Member

@auduchinok auduchinok commented Feb 27, 2020

Fixes problems with _ self id ranges in members (from #7631). The added rule was copied from existing one and some of its parts didn't have indices properly updated.

@auduchinok auduchinok force-pushed the member-wildSelfId-range branch 2 times, most recently from 0ef7dbe to 9b7d304 Compare February 27, 2020 18:58
@auduchinok auduchinok force-pushed the member-wildSelfId-range branch from 9b7d304 to 40b45c9 Compare February 27, 2020 18:58
@auduchinok auduchinok changed the title Fix wild self id pat range, simplify grammar Fix wild self id pat range Feb 27, 2020
Copy link
Copy Markdown
Contributor

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,

thank you for this.

@cartermp cartermp merged commit 808996b into dotnet:master Feb 28, 2020
@auduchinok auduchinok deleted the member-wildSelfId-range branch February 28, 2020 11:23
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants