Do not merge - alternate fix for issue 8351 kr #9445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added another property that is expected to fail, exhibiting inconsistencies in how the error is reported depending if the type is defined in F# or not.
KevinRansom
force-pushed
the
fix-for-issue-8351-kr
branch
2 times, most recently
from
ce0892d to
859ce1d
Compare
KevinRansom
force-pushed
the
fix-for-issue-8351-kr
branch
from
859ce1d to
b88ba3c
Compare
Merged
TIHan
reviewed
Jun 15, 2020
Co-authored-by: Gauthier Segay <smoothdeveloper@users.noreply.github.com>
Co-authored-by: Gauthier Segay <smoothdeveloper@users.noreply.github.com>
Contributor
Author
|
Pushed updates back to: source pr : #8354 |
Contributor
|
@KevinRansom somehow I don't see ee6fd8e in the source PR? is it possible to integrate it as well? |
Contributor
Author
|
Let me take a look, it should be there. |
Contributor
Author
|
@smoothdeveloper ... bugger it got lost. |
Contributor
Author
|
Updated: 24b4d28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains @smoothdeveloper 's fix and test updates.
Includes :