Open Type Declaration updates #9513

TIHan · 2020-06-20T06:21:26Z

Design
- https://github.com/fsharp/fslang-design/blob/master/FSharp-5.0/FS-1068-open-type-declaration.md
Implementation
- open type on nominal types
- open type on types with generic parameterization
- Match resolution ambiguity behavior of opened content to how it works after a dot.
- Cleanup some implementation details
- Support opening unions
  - Access to union cases
  - Support generics (enclosing type instantiations)
- Support opening records
  - Access to record labels
  - Support generics (enclosing type instantiations)
- Combine method groups for a type's extension and intrinsic methods
- Support opening enums
Tooling
- Completions on open type
Tests
- Tests on nominal types
- Tests on types with generic parameterization
  - Simple generic types
  - Nested generic types
  - Complex types with many type parameters with nested generic types
- Tests on nested types including ones that are generic
- Partially convert tests to newer test framework
- Type provider tests - Generated and Erased
- Various uses of units of measure, either by opening the units of measure type or types annotated with units of measure
- Add union tests
- Add record tests
- Add enum tests
- Add more ambiguity tests
- Signature file test
- AutoOpen and assembly test
- Re-enable completions test case on attributes

tests/fsharp/Compiler/Language/OpenTypeDeclarationTests.fs

TIHan · 2020-08-04T04:35:52Z

I'll need to do some more updates due to nameof being merged.

cartermp · 2020-08-06T22:42:44Z

tests/fsharp/Compiler/Language/OpenTypeDeclarationTests.fs

+
+    let y = M()
+        """
+        |> withOptions ["--langversion:preview"]


can now do withPreview :)

dsyme · 2020-08-10T20:12:18Z

vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.Completion.fs

-
-    [<Test>]
-    member this.``Attributes.CanSeeOpenNamespaces.Bug268290.Case2``() =
-        AssertCtrlSpaceCompleteContains 


Hmm do you know why this test case was removed?

I don't think I remember; I should try to enable it again.

dsyme · 2020-08-10T20:14:06Z

This looks great and is ready to go in.

During the spec/code review today we spotted a couple of things which can be addressed as bug fixes after this is integrated

Extension methods and intrinsic methods of the same name should merge into one method set
I've forgotten the other tthing, @TIHan has a note :-)

dsyme · 2020-08-10T20:16:12Z

@TIHan I made a note of a few other things you might like to check

In F# it's possible to add AutoOpen to an assembly, in which case that path is automatically opened. This feature is rarely used, and is mainly for FSHarp.Core. We should verify if it is/isn't possible to use this with open type. My belief from the code is that it is not possible. That's ok, we should just know whether it is an note it in the RFC
Are there tests for open type in a signature file? I believe from the code that it will work just fine.

dsyme · 2020-08-10T20:16:50Z

@TIHan please resolve the xlf conflicts, thanks :-)

…ord/union tests.

TIHan · 2020-08-10T22:04:28Z

For reference, here is the final bug we need to fix: #9914

TIHan · 2020-08-10T22:15:17Z

In F# it's possible to add AutoOpen to an assembly, in which case that path is automatically opened. This feature is rarely used, and is mainly for FSHarp.Core. We should verify if it is/isn't possible to use this with open type. My belief from the code is that it is not possible. That's ok, we should just know whether it is an note it in the RFC

Didn't know about this ability. I'll have to make a test case and see.

Are there tests for open type in a signature file? I believe from the code that it will work just fine.

No tests on signature files. We should just in case.

TIHan · 2020-08-10T22:38:00Z

Made note of more test cases:
#9914
#9916

cartermp · 2020-08-11T04:32:18Z

🎉

cartermp · 2020-08-11T04:32:24Z

🌮

cartermp · 2020-08-11T04:32:34Z

🐔 or 🐮 ?

* Allow using nested types in unqualified scenarios * Renaming OpenStaticClasses to OpenTypeDeclaration * Added 'open type' declaration * Added more tests * Fixing build * Added tooling support * More updates * Some refactor * open static prototype * open static prototype * Fixes on merge * Fixing build * Fixing some tests * Trying to figure out nested * Added eUnqualifiedTyconTypeArgs * Properly opening generic types with nested generic types * Update test baseline * Include range on target * Fixing build * Fixing build * Fixing build * Error if not an appty * Slightly better error * Getting tests to pass * Trying to fix tests * Get current tests to pass * Partial working unused opens * Almost there * Some fixed * Reverting back to original service analysis * Fixed test * Fixed test * Fixed build * Fixing tests * Fixing tests * Fixing more tests * Removing broken tests * Added more tests. Checking for byrefs * More tests * More tests * Update tests * Rename * Better names * Added test case for inherited members * Added more tests with CSharp style extension members * Minor format * Minor updates * Fixing nested types * Fixed nested types possibly * Trying to fix it * Some cleanup * More cleanup * Partial * Partially working * Fixed nested types * Fixing tests * Removed NumStaticArgs * Rename AddEntties/OpenEntities to AddModuleOrNamespaceRefs/OpenModuleOrNamespaceRefs * minor cleanup * Minor rename * Another rename * Update src/fsharp/symbols/Symbols.fs Co-authored-by: Phillip Carter <pcarter@fastmail.com> * Trying to add type provider test * Remove type provider test for now * Starting to convert tests * More tests converted * More tests converted * more tests converted * Added type provider tests * Added complex generic types with nested generic types * Added units of measure tests and named types * Added more tests * Added two more tests * Added one more test * Added enum test case * Added enum tests and support * Adding union case support * Removing unions support * Fixing build * Disallowing operators to come into scope * Minor refactoring * Access to record labels and union cases * Fixing opening generic types * Do not need to return enclosing type instantiations from a dot * Added generic union and record tests * Combining intrinsic and extension method groups. Ignoring generic record/union tests. * Update FSComp.txt.ja.xlf * Fixing build * Update OpenTypeDeclarationTests.fs Co-authored-by: Don Syme <dsyme@microsoft.com> Co-authored-by: Phillip Carter <pcarter@fastmail.com>

Allow using nested types in unqualified scenarios

14fd06f

TIHan mentioned this pull request Jun 20, 2020

Open Static Classes - Updates #7405

Closed

TIHan added 2 commits June 22, 2020 14:53

Renaming OpenStaticClasses to OpenTypeDeclaration

eabfc6a

Added 'open type' declaration

69f1328

TIHan changed the title ~~[WIP] Open Static Classes updates~~ [WIP] Open Type Declaration updates Jun 23, 2020

TIHan and others added 12 commits June 22, 2020 18:39

Added more tests

b5ecdd8

Fixing build

ed170c0

Added tooling support

3987aea

More updates

0ec3f63

Some refactor

f928b2f

open static prototype

e7bebce

open static prototype

23a9d3a

Merging master and Don's changes

847345c

Fixes on merge

5feed0a

Fixing build

d885764

Fixing some tests

6ebd971

Trying to figure out nested

4135fce

cartermp reviewed Jun 25, 2020

View reviewed changes

tests/fsharp/Compiler/Language/OpenTypeDeclarationTests.fs Outdated Show resolved Hide resolved

cartermp added the Candidate for F# 5 label Jun 25, 2020

TIHan added 11 commits June 27, 2020 18:06

Added eUnqualifiedTyconTypeArgs

a3f16dc

Properly opening generic types with nested generic types

d3e4bbf

Update test baseline

c4f9a93

Include range on target

94c0892

Fixing build

3b37aa8

Fixing build

7d0a5c3

Fixing build

7169f9f

Error if not an appty

022a25b

Slightly better error

0307cb8

Getting tests to pass

ad5734e

Trying to fix tests

eaca692

TIHan added 9 commits August 4, 2020 17:16

Merged master

46602ff

Removing unions support

cf030ef

Fixing build

72bae82

Disallowing operators to come into scope

6eda4ce

Minor refactoring

7e88f52

Access to record labels and union cases

08731c5

Fixing opening generic types

edab625

Do not need to return enclosing type instantiations from a dot

07bd541

Added generic union and record tests

6ec6a41

cartermp reviewed Aug 6, 2020

View reviewed changes

dsyme reviewed Aug 10, 2020

View reviewed changes

dsyme approved these changes Aug 10, 2020

View reviewed changes

Combining intrinsic and extension method groups. Ignoring generic rec…

9d3b4bd

…ord/union tests.

Merge branch 'master' into feature/open-static-classes-cont

223edf5

cartermp approved these changes Aug 10, 2020

View reviewed changes

Update FSComp.txt.ja.xlf

ff3975f

TIHan added 2 commits August 10, 2020 15:42

Fixing build

5848087

Update OpenTypeDeclarationTests.fs

1151da5

TIHan merged commit f38e957 into dotnet:master Aug 11, 2020

Open Type Declaration updates #9513

Open Type Declaration updates #9513

Uh oh!

Conversation

TIHan commented Jun 20, 2020 • edited by dsyme Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TIHan commented Aug 4, 2020

Uh oh!

cartermp Aug 6, 2020

Choose a reason for hiding this comment

Uh oh!

dsyme Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

TIHan Aug 10, 2020

Choose a reason for hiding this comment

Uh oh!

dsyme commented Aug 10, 2020

Uh oh!

dsyme commented Aug 10, 2020

Uh oh!

dsyme commented Aug 10, 2020

Uh oh!

TIHan commented Aug 10, 2020

Uh oh!

TIHan commented Aug 10, 2020

Uh oh!

TIHan commented Aug 10, 2020

Uh oh!

cartermp commented Aug 11, 2020

Uh oh!

cartermp commented Aug 11, 2020

Uh oh!

cartermp commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TIHan commented Jun 20, 2020 •

edited by dsyme

Loading