-
Notifications
You must be signed in to change notification settings - Fork 847
Eager Packages #9652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eager Packages #9652
Conversation
|
Is there a test to demonstrate this behavior change? |
|
@cartermp yes. Although doesn't handle the #i thats a different work item. |
|
@KevinRansom I believe this is going to impact paket integration, IIUC it commits each line as soon as they come, which will trigger restore more than once, with potentially conflicting dependencies (when 2 packages are added with transitive dependencies). The fact that the lines were only committed after encountering |
|
@smoothdeveloper , this change does indeed resolve every line, which is not the intent. The intent is to resolve once per commit. More work to do. |
a106c53 to
702d5a8
Compare
702d5a8 to
0a7116b
Compare
comment
* Couple of test cases * Eager packages * Update fsi.fs comment
With the current implementation of the package manager resolution is delayed until code is generated and executed. This has the side effect that errors are not displayed until later than expected.
It is commonly believed by developers that:
#r "nuget:FSharp.Data";; should resolve and display errors immediately.
It is somewhat jarring to see:
and then see the error happen when generating code:
This PR, makes resolution and error reporting eager.