Skip to content

Remove string allocation #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 1 commit into from
Jul 17, 2020
Merged

Remove string allocation #9706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/fsharp/FSharp.Core/reflect.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,9 @@ module internal Impl =
let nm = minfo.Name
// chop "get_" or "New" off the front
let nm =
if not (isListType typ) && not (isOptionType typ) then
if nm.Length > 4 && nm.[0..3] = "get_" then nm.[4..]
elif nm.Length > 3 && nm.[0..2] = "New" then nm.[3..]
if not (isListType typ) && not (isOptionType typ) && nm.Length > 3 then
if nm.StartsWith ("get_", StringComparison.Ordinal) then nm.[4..]
elif nm.StartsWith ("New", StringComparison.Ordinal) then nm.[3..]
else nm
else nm
Some (n, nm)
Expand Down