Allow use of only netstandard2.0 FSharp.Compiler.Private to ease development in VS #9766
Conversation
dsyme
changed the title
dsyme
changed the title
|
See also #7959 |
If this indeed makes working in Can we place that comment in the |
|
@brettfo One thing I noticed was that System.Reflection.TypeExtensions.dll was missing from the list of DLLs to package with |
Not yet - while this PR is useful it's not ready for common scenario yet, too many tests fail |
| <Tailcalls>true</Tailcalls> <!-- .tail annotations always emitted for this binary, even in debug mode --> | ||
| </PropertyGroup> | ||
|
|
||
| <Target Name="CopyToBuiltBin" BeforeTargets="BuiltProjectOutputGroup" AfterTargets="CoreCompile"> |
There was a problem hiding this comment.
This target needs to stay in this file because this is where the package references live. It's simply an implementation detail that they also end up next to fsc in the output and if that ever changes we'll be in for a world of hurt trying to figure out what changed.
I'm guessing this changed because building only netstandard2.0 here means not all of the files are present, e.g., Microsoft.Build.dll. If that's the case, those BuildProjectOutputGroupKeyOutput items could be made to behave better with Condition="'$(TargetFramework)' == 'net472'"
There was a problem hiding this comment.
ok i see thanks (out of curiosity could you also put package references in FSC?)
| folder "InstallDir:Common7\IDE\CommonExtensions\Microsoft\FSharp" | ||
| file source="$(BinariesFolder)\fsc\$(Configuration)\$(TargetFramework)\fsc.exe" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 vs.file.ngenApplication="[installDir]\Common7\IDE\CommonExtensions\Microsoft\FSharp\fsc.exe" | ||
| file source="$(BinariesFolder)\fsc\$(Configuration)\$(TargetFramework)\fsc.exe.config" | ||
| file source="$(BinariesFolder)\fsc\$(Configuration)\$(TargetFramework)\Microsoft.Build.dll" |
There was a problem hiding this comment.
I'd rather these references come specifically from the project output dir that originally requested them, e.g., FSharp.Compiler.Private for most.
| file source="$(BinariesFolder)\FSharp.Compiler.Private\$(Configuration)\$(TargetFramework)\System.Resources.Extensions.dll" | ||
| file source="$(BinariesFolder)\FSharp.Compiler.Private\$(Configuration)\$(TargetFramework)\System.Runtime.CompilerServices.Unsafe.dll" | ||
| file source="$(BinariesFolder)\FSharp.Compiler.Private\$(Configuration)\$(TargetFramework)\System.Threading.Tasks.Dataflow.dll" | ||
| file source="$(BinariesFolder)\FSharp.Compiler.Server.Shared\$(Configuration)\$(TargetFramework)\FSharp.Compiler.Server.Shared.dll" vs.file.ngen=yes vs.file.ngenArchitecture=All vs.file.ngenPriority=2 |
There was a problem hiding this comment.
This one specifically should remain.
|
This is on my list to do properly. |
fab |
|
I'll close this as I'm not yet regularly using it (got a bunch of test failures related to this in a test I needed to actually run for the string interpolation work) |
4 participants
This eases a development pain where the use of multi-targeting for FSHarp.COmpiler.Private badly stresses our VS tooling while working on the compiler itself. It makes it easier for developers to locally use only a netstandard2.0 FSharp.Compiler.Private.dll ,for compiler work/testing etc, giving much faster IDE support.
This is a benign change
it doesn't change the product
It is not activated by default (the comment in FSHarp.Compiler.Private.fsproj indicates how to activate it.)
doesn't actually try to use .NET Standard 2.0 dll any more than it's used so far
when you enable it you can't actually build a full working VSIX but I've verified you can build the compiler and run individual unit tests, right the way up to the VIsual Studio unit test
#7959 contains some further fixes which @cartermp found for packaging etc.
Notes:
For IndentedTextWriter, the necessary code is in .NET Standard 2.0 to activate this. This change will also include this functionality in FCS
The other change moves the "grab these extra DLLs for VS setup" logic into fsc project