Add implementation for -excludeCIBinaryLog #9816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinRansom
force-pushed
the
excludeCIBinaryLog
branch
from
e55feec to
4a8f29e
Compare
Contributor
|
Cool! Glad you could fix it so quickly! |
cartermp
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9814 -- Running tests with -ci requires -excludeCIBinarylog switch, which doesn't exist
In the build we verify that when we are running under the CI we specify production of a binary log. The -excludeCIBinarylog was intended to allow a developer who knew they didn't need a binary log when specifying -CI could specify that, which would allow us to skip production of the binaryLog. However, the implementation for it disappeared or never materialized because "busyness".
This PR adds it in.