Skip to content

Conversation

@KevinRansom
Copy link
Contributor

@KevinRansom KevinRansom commented Aug 2, 2020

In FSharp.Compiler.Private , FSharp.DependencyManager and FSharp.VS.FSI, we used a hard coded string.

This PR, puts it in a localized resource file and updates the projects to use the localized version.

#if LOCALIZATION_FSBUILD
    let FSharpBannerVersion = FSBuild.SR.fSharpBannerVersion(FSharp.BuildProperties.fsProductVersion, FSharp.BuildProperties.fsLanguageVersion)
#else
#if LOCALIZATION_FSCOMP
    let FSharpBannerVersion = FSComp.SR.fSharpBannerVersion(FSharp.BuildProperties.fsProductVersion, FSharp.BuildProperties.fsLanguageVersion)
#else
    let FSharpBannerVersion = sprintf "%s for F# %s" (FSharp.BuildProperties.fsProductVersion) (FSharp.BuildProperties.fsLanguageVersion)
#endif
#endif

Amusingly we localized it in FSharp.Build and the Compiler Service, but elsewehere we just used the sprintf

@cartermp cartermp merged commit 129f9ec into dotnet:master Aug 3, 2020
@KevinRansom KevinRansom deleted the localize branch August 19, 2020 20:21
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants