ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failure#107
Closed
akoeplinger wants to merge 1 commit intodotnet:maint/maint-67from
Closed
ICU-21591 Release lock in SimpleDateFormat::tzFormat in case of failure#107akoeplinger wants to merge 1 commit intodotnet:maint/maint-67from
akoeplinger wants to merge 1 commit intodotnet:maint/maint-67from
Conversation
Also remove the use of the unsafe double-checked lock idiom in the same function, SimpleDateFormat::tzFormat(). Synchronization now always uses a mutex, which is slower, but in the context of format or parse operations, shouldn't be significant. Added synchronization to one more unsafe direct reference to a const SimpleDateFormat::fTimeZoneFormat. In the assignment operator.
Member
Author
|
Hmm looks like this would require backporting more changes to the maint-67 branch since it's missing e.g. unicode-org/icu@afa9b9b I don't think it's worth it since we have plans to bump to icu 68 anyway, @filipnavara what do you think? |
Member
|
I don't think it's worth it to be honest. The call will either always fail or always succeed in the way it's used in .NET so the additional memory protections are not gonna make much difference. |
directhex
pushed a commit
that referenced
this pull request
May 13, 2022
Bumps ant from 1.10.9 to 1.10.11. --- updated-dependencies: - dependency-name: org.apache.ant:ant dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of unicode-org/icu#1701 which is a slightly modified fix for #103
/cc @filipnavara