Fix patch removing aspnetcore apphost pack prebuilt#12469
Merged
MichaelSimons merged 1 commit intoOct 21, 2021
Conversation
dagood
force-pushed
the
prebuilt-apphost-aspnetcore
branch
from
2f38713 to
0aa29d7
Compare
Member
Author
|
Confirmed that in my local build, aspnetcore's prebuilt report is empty and the global prebuilt report no longer has this line: (Only 3.1.18 and 5.0.9 are listed and only in the global report. These are known from other repos.) |
dagood
force-pushed
the
prebuilt-apphost-aspnetcore
branch
from
0aa29d7 to
388ed26
Compare
| + Source-build doesn't run tests, so the property is simply conditioned out. | ||
| + --> | ||
| + <LocalDotNetRoot Condition="'$(DotNetBuildFromSource)' != 'true' or '$(UseAppHost)' != 'true'">$(RepoRoot).dotnet\</LocalDotNetRoot> | ||
| + <NetCoreTargetingPackRoot Condition="'$(LocalDotNetRoot)' != ''">$(LocalDotNetRoot)packs\</NetCoreTargetingPackRoot> |
Member
There was a problem hiding this comment.
Ah...Reviewing patch changes in GitHub with the unified view is terribly confusing!
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See dotnet/aspnetcore#37672 for info on the mistake, and the fix. Essentially: