Build Microsoft.NET.Build.Tasks for netfx#12497
Merged
Merged
Conversation
crummel
approved these changes
Oct 22, 2021
MichaelSimons
approved these changes
Oct 22, 2021
dseefeld
approved these changes
Oct 22, 2021
dagood
approved these changes
Oct 22, 2021
Comment on lines
+44
to
+48
| + <!-- This is working around a source-build issue with NuGet. Since NuGet isn't building for netfx in source-build, this reference isn't getting set automatically --> | ||
| + <!-- This can be removed once NuGet builds for netfx in source-build. --> | ||
| + <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'"> | ||
| + <Reference Include="System.IO.Compression" /> | ||
| + </ItemGroup> |
Member
There was a problem hiding this comment.
This can be removed once NuGet builds for netfx in source-build.
Maybe worth pointing to an issue tracking this if there is one--for the same of time, maybe just mentioning this part of the patch in dotnet/sdk#22281 and including a link. Just so the context isn't lost before someone dives into the patch integration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required for omnisharp to work with a source-built .NET SDK.
Patch removal issue: dotnet/sdk#22281