[release/7.0.1xx] Update dependencies from dotnet/sdk by dotnet-maestro[bot] · Pull Request #14616 · dotnet/installer

dotnet-maestro · 2022-09-29T05:19:55Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.WindowsDesktop.App.Ref: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Ref: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- Microsoft.NETCore.Platforms: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Ref.Internal: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- Microsoft.AspNetCore.App.Runtime.win-x64: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- dotnet-dev-certs: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-jwts: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- dotnet-user-secrets: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3 (parent: Microsoft.NET.Sdk)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk)
- Microsoft.Net.Compilers.Toolset: from 4.4.0-2.22464.20 to 4.4.0-3.22478.13 (parent: Microsoft.NET.Sdk)
- Microsoft.Build: from 17.4.0-preview-22477-01 to 17.4.0-preview-22479-02 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

Subscription: 954a90b8-b6f2-4bea-40e6-08da7ef5fc68
Build: 20220929.10
Date Produced: September 29, 2022 8:23:16 PM UTC
Commit: da2c864
Branch: refs/heads/release/7.0.1xx

Updates:
- Microsoft.DotNet.Common.ItemTemplates: from 7.0.100-rtm.22478.5 to 7.0.100-rtm.22479.10
- Microsoft.DotNet.MSBuildSdkResolver: from 7.0.100-rtm.22478.5 to 7.0.100-rtm.22479.10
- Microsoft.NET.Sdk: from 7.0.100-rtm.22478.5 to 7.0.100-rtm.22479.10
- Microsoft.TemplateEngine.Cli: from 7.0.100-rtm.22478.5 to 7.0.100-rtm.22479.10
- Microsoft.WindowsDesktop.App.Ref: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5
- VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5
- VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5
- Microsoft.NETCore.App.Runtime.win-x64: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- Microsoft.NETCore.App.Ref: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- VS.Redist.Common.NetCore.TargetingPack.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- Microsoft.NETCore.App.Host.win-x64: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- Microsoft.NETCore.DotNetHostResolver: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- Microsoft.NETCore.Platforms: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- Microsoft.AspNetCore.App.Ref: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- Microsoft.AspNetCore.App.Ref.Internal: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- Microsoft.AspNetCore.App.Runtime.win-x64: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- dotnet-dev-certs: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- dotnet-user-jwts: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- dotnet-user-secrets: from 7.0.0-rtm.22477.1 to 7.0.0-rtm.22479.3
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 7.0.0-rtm.22476.10 to 7.0.0-rtm.22478.5
- Microsoft.Net.Compilers.Toolset: from 4.4.0-2.22464.20 to 4.4.0-3.22478.13
- Microsoft.Build: from 17.4.0-preview-22477-01 to 17.4.0-preview-22479-02
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9
- VS.Redist.Common.NetCore.SharedFramework.x64.7.0: from 7.0.0-rtm.22476.12 to 7.0.0-rtm.22478.9

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.100-rtm.22478.5 -> To Version 7.0.100-rtm.22478.9 Dependency coherency updates Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.7.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.Build,VS.Redist.Common.NetCore.SharedFramework.x64.7.0,VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rtm.22476.12 -> To Version 7.0.0-rtm.22478.4 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.100-rtm.22478.5 -> To Version 7.0.100-rtm.22478.12 Dependency coherency updates Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.7.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Net.Compilers.Toolset,Microsoft.Build,VS.Redist.Common.NetCore.SharedFramework.x64.7.0,VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rtm.22476.10 -> To Version 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk

v-wuzhai · 2022-09-29T09:34:39Z

@dotnet/source-build-internal Could you take a look at the failures here?

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.100-rtm.22478.5 -> To Version 7.0.100-rtm.22479.3 Dependency coherency updates Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.7.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Net.Compilers.Toolset,Microsoft.Build,VS.Redist.Common.NetCore.SharedFramework.x64.7.0,VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rtm.22476.10 -> To Version 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.100-rtm.22478.5 -> To Version 7.0.100-rtm.22479.5 Dependency coherency updates Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.7.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Net.Compilers.Toolset,Microsoft.Build,VS.Redist.Common.NetCore.SharedFramework.x64.7.0,VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rtm.22476.10 -> To Version 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk

MichaelSimons · 2022-09-29T14:19:58Z

@dotnet/source-build-internal Could you take a look at the failures here?

I have pushed a fix.

MichaelSimons · 2022-09-29T15:45:15Z

cc @lbussell - the latest roslyn compiler is flowing in so the runtime patch is needed you prepped.

MichaelSimons · 2022-09-29T17:34:40Z

@rainersigwald, @jaredpar - Source-build is failing to build msbuild with there changes with the following errors. I am assuming this is an issue caused by building msbuild with the latest roslyn flowing in here.

    /repos/tarball-temp/src/msbuild/artifacts/source-build/self/src/src/StringTools/InternableString.cs(173,39): error CS8170: Struct members cannot return 'this' or other instance members by reference [/repos/tarball-temp/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=net7.0]
    /repos/tarball-temp/src/msbuild/artifacts/source-build/self/src/src/StringTools/InternableString.cs(173,20): error CS8347: Cannot use a result of 'InternableString.Enumerator.Enumerator(ref InternableString)' in this context because it may expose variables referenced by parameter 'str' outside of their declaration scope [/repos/tarball-temp/src/msbuild/artifacts/source-build/self/src/src/StringTools/StringTools.csproj::TargetFramework=net7.0]

rainersigwald · 2022-09-29T17:38:26Z

Looks like something we worked around but then backed out the workaround for (dotnet/msbuild#7790 (comment)).

rainersigwald · 2022-09-29T17:39:36Z

. . . but that was fixed in later Roslyn, so I'm confused about what's happening here.

jaredpar · 2022-09-29T17:42:58Z

@rainersigwald

internal Enumerator(ref InternableString str)

Needs to be

internal Enumerator(scoped ref InternableString str)

MichaelSimons · 2022-09-29T19:13:54Z

Thanks @jaredpar and @rainersigwald. I added a source-build patch to unblock this dependency flow I also opened a tracking issue in msbuild. I would appreciate sign-off on the source-build patch until msbuild picks up the new roslyn version.

rainersigwald · 2022-09-29T19:32:45Z

patch lgtm.

@jaredpar is that a required permanent fix? I thought it was a workaround for a now-fixed bug, which is why I reverted it.

jaredpar · 2022-09-29T20:26:42Z

@jaredpar is that a required permanent fix?

It's permanent until we change the design again 😄

I thought it was a workaround for a now-fixed bug, which is why I reverted it.

How ref capture works is a core problem we've been struggling with in the ref field design. The initial design went too far into the "let everything be captured" space, that lead to a number of compat breaks so we tweaked on aspect severely in the other direction, and after more refinement ended up in a more explainable place. Essentially any ref can be captured in the return of the method or out parameters. In this case it's a ctor, it has a ref so that can be captured but you don't intend that here so scoped to tell us it can't happen.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli From Version 7.0.100-rtm.22478.5 -> To Version 7.0.100-rtm.22479.10 Dependency coherency updates Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.7.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.7.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.7.0,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.7.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Net.Compilers.Toolset,Microsoft.Build,VS.Redist.Common.NetCore.SharedFramework.x64.7.0,VS.Redist.Common.NetCore.SharedFramework.x64.7.0 From Version 7.0.0-rtm.22476.10 -> To Version 7.0.0-rtm.22478.5 (parent: Microsoft.NET.Sdk

Backport: dotnet/installer#14616 Co-Authored-By: Jared Parsons <jaredpar@microsoft.com>

Backport: dotnet/installer#14616 Co-Authored-By: Jared Parsons <jaredpar@microsoft.com> Co-authored-by: MichaelSimons <msimons@microsoft.com> Co-authored-by: Jared Parsons <jaredpar@microsoft.com>

dotnet-maestro Bot added 2 commits September 29, 2022 05:19

dotnet-maestro Bot and others added 3 commits September 29, 2022 11:02

Remove backported source-build patches

7db152d

MichaelSimons requested a review from a team as a code owner September 29, 2022 14:19

Update compiler version in runtime

a5705a7

MichaelSimons mentioned this pull request Sep 29, 2022

InternableString.cs fails to compile w/latest roslyn dotnet/msbuild#8014

Closed

Add patch to address build issue in msbuild

a47b8be

v-wuzhai approved these changes Sep 30, 2022

View reviewed changes

v-wuzhai merged commit c286525 into release/7.0.1xx Sep 30, 2022

v-wuzhai deleted the darc-release/7.0.1xx-aaa9a7ec-ca46-4f1a-b8e4-bfe19157990c branch September 30, 2022 01:43

rainersigwald pushed a commit to rainersigwald/msbuild that referenced this pull request Sep 30, 2022

Updates to build w/latest roslyn

afd8672

Backport: dotnet/installer#14616 Co-Authored-By: Jared Parsons <jaredpar@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/7.0.1xx] Update dependencies from dotnet/sdk#14616

[release/7.0.1xx] Update dependencies from dotnet/sdk#14616
v-wuzhai merged 8 commits intorelease/7.0.1xxfrom
darc-release/7.0.1xx-aaa9a7ec-ca46-4f1a-b8e4-bfe19157990c

dotnet-maestro Bot commented Sep 29, 2022 •

edited

Loading

Uh oh!

v-wuzhai commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

jaredpar commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

jaredpar commented Sep 29, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

dotnet-maestro Bot commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coherency Updates

From https://github.com/dotnet/sdk

Uh oh!

v-wuzhai commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

jaredpar commented Sep 29, 2022

Uh oh!

MichaelSimons commented Sep 29, 2022

Uh oh!

rainersigwald commented Sep 29, 2022

Uh oh!

jaredpar commented Sep 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dotnet-maestro Bot commented Sep 29, 2022 •

edited

Loading

jaredpar commented Sep 29, 2022 •

edited

Loading