Skip to content

Include RID in SB artifact file names#15320

Merged
MichaelSimons merged 2 commits intodotnet:mainfrom
mthalman:sb2928
Jan 25, 2023
Merged

Include RID in SB artifact file names#15320
MichaelSimons merged 2 commits intodotnet:mainfrom
mthalman:sb2928

Conversation

@mthalman
Copy link
Copy Markdown
Member

@mthalman mthalman requested a review from a team as a code owner January 20, 2023 17:00
@MichaelSimons
Copy link
Copy Markdown
Member

@lbussell, @crummel - Thoughts on how should we handle this change in prep.sh and the release pipeline. The prep script UX feels a bit odd now in that the default behavior would only work on centos.8. The UX needs refactoring.

@MichaelSimons
Copy link
Copy Markdown
Member

@lbussell, @crummel - Thoughts on how should we handle this change in prep.sh and the release pipeline. The prep script UX feels a bit odd now in that the default behavior would only work on centos.8. The UX needs refactoring.

To clarify this PR is not what is changing the behavior of the prep script - it was the removal of the runtime portable artifacts. This change just calls out the default behavior only works for a single rid.

@lbussell
Copy link
Copy Markdown
Member

cc @premun for artifact name changes that might affect 8.0 servicing pipelines.

@premun
Copy link
Copy Markdown
Member

premun commented Jan 25, 2023

Thanks for the notice, I will have to double check the VMR CI too. The step that re-uses the previously built SDK might depend on this.

@MichaelSimons
Copy link
Copy Markdown
Member

Thanks for the notice, I will have to double check the VMR CI too. The step that re-uses the previously built SDK might depend on this.

It doesn't look like it does. https://github.com/dotnet/installer/blob/main/eng/pipelines/templates/jobs/vmr-build.yml#L143. It utilizes wild card patterns.

@MichaelSimons
Copy link
Copy Markdown
Member

@lbussell, @crummel - Thoughts on how should we handle this change in prep.sh and the release pipeline. The prep script UX feels a bit odd now in that the default behavior would only work on centos.8. The UX needs refactoring.

This is tracked with dotnet/source-build#3222.

@MichaelSimons MichaelSimons merged commit 03938ae into dotnet:main Jan 25, 2023
@mthalman mthalman deleted the sb2928 branch January 26, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source-built artifacts and smoke-test prereqs tarballs should include arch in their names

5 participants