Patch for MSBuild reference of System.Security.Permissions#17246
Patch for MSBuild reference of System.Security.Permissions#17246mthalman wants to merge 1 commit into
Conversation
|
msbuild has been flowing in pretty fast. Thoughts on just waiting for it versus adding a patch that will require manual removal in the dependency flow (usually delaying the process)? |
| + <Dependency Name="System.Security.Permissions" Version="7.0.0"> | ||
| + <Uri>https://github.com/dotnet/runtime</Uri> | ||
| + <Sha>d099f075e45d2aa6007a22b71b45a08758559f80</Sha> | ||
| + </Dependency> |
There was a problem hiding this comment.
@mthalman for my understanding of what this does:
When building the msbuild repo, when the build normally uses the System.Security.Permissions version 7.0.0 package, during source-build, it will use the live version package instead.
Does live version mean: the latest version available?
What are the Uri and Sha for?
There was a problem hiding this comment.
Does live version mean: the latest version available?
What are the Uri and Sha for?
Generally speaking it means either
- The current version being source-built - if the dependent package was already built during the full source build
- The n-1 version coming from the previous artifacts - if the dependent package was not already built during the full source build. If this is the case, the reference package is not allowed to be bundled as that would break the source build rules and would get detected by the poison infrastructure.
That seems fine. A patch would have allowed for faster validation of the fix but that's already been done (dotnet/source-build#3571 (comment)). |
3 participants
Patch for dotnet/msbuild#9158
Fixes dotnet/source-build#3571