Skip to content

Enable error on prebuilts#18173

Merged
MichaelSimons merged 4 commits intodotnet:mainfrom
ellahathaway:enable-prebuilt-detection
Feb 8, 2024
Merged

Enable error on prebuilts#18173
MichaelSimons merged 4 commits intodotnet:mainfrom
ellahathaway:enable-prebuilt-detection

Conversation

@ellahathaway
Copy link
Copy Markdown
Member

Re-enables errors when prebuilts are detected. This was originally disabled in 4e3e6d9.

Relates to dotnet/source-build#3665

@ellahathaway ellahathaway requested a review from a team as a code owner January 9, 2024 23:59
@MichaelSimons
Copy link
Copy Markdown
Member

Blocked on dotnet/arcade#14353 flowing into installer.

@ellahathaway ellahathaway force-pushed the enable-prebuilt-detection branch from da17cf0 to 85b51be Compare January 17, 2024 23:45
@ellahathaway
Copy link
Copy Markdown
Member Author

This PR should be unblocked now. I merged in main and made the appropriate changes.

@ellahathaway
Copy link
Copy Markdown
Member Author

Blocked by dotnet/source-build#3985

@MichaelSimons MichaelSimons enabled auto-merge (squash) February 7, 2024 20:29
@ellahathaway
Copy link
Copy Markdown
Member Author

@mmitche - We're detecting a new prebuilt, Microsoft.DotNet.Arcade.Sdk.9.0.0-beta.24075.2. Any chance this might be related to the changes that happened in #18539? Thanks in advance!

@mmitche
Copy link
Copy Markdown
Member

mmitche commented Feb 7, 2024

@mmitche - We're detecting a new prebuilt, Microsoft.DotNet.Arcade.Sdk.9.0.0-beta.24075.2. Any chance this might be related to the changes that happened in #18539? Thanks in advance!

Possibly? I would be surprised though...let me look.

@ellahathaway
Copy link
Copy Markdown
Member Author

@mmitche - We're detecting a new prebuilt, Microsoft.DotNet.Arcade.Sdk.9.0.0-beta.24075.2. Any chance this might be related to the changes that happened in #18539? Thanks in advance!

Possibly? I would be surprised though...let me look.

Whoops, realized that this is being discussed internally. Also appears that #18505 might be the cause. Sorry for the ping!

@MichaelSimons MichaelSimons merged commit b368584 into dotnet:main Feb 8, 2024
@ellahathaway ellahathaway deleted the enable-prebuilt-detection branch February 14, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants