Fix msbuild downgrade issue

[NikolaMilosavljevic]

Fixes: dotnet/source-build#4344

dotnet/runtime#100595 introduced two issues:

• Lower MSBuild version dependency - 17.8.3, instead of 17.8.5. This caused transitive package downgrade errors.
• Source-build dependency for MSBuild, in runtime repo. This caused downgrade of MSBuild repo in VMR, from 17.8.5 to 17.8.3.

Besides removing direct package references, the fix is to add a direct MSBuild source-build dependency in installer repo

[MichaelSimons]

This doesn't look like the right location - this should be in the appropriate patch folder.

[NikolaMilosavljevic]

Hmm, not sure how this happened - fixing.

[NikolaMilosavljevic]

Fixed with 74acebd

[MichaelSimons]

Please add a backport link.

[NikolaMilosavljevic]

Fixed with a3610f6

[NikolaMilosavljevic]

Additional issue was discovered in internal validation build, in online scenarios:

2024-04-20T01:46:27.0235861Z     /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605: Warning As Error: Detected package downgrade: Microsoft.Build.Framework from 17.8.5 to 17.8.3. Reference the package directly from the project to select a different version.  [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]
2024-04-20T01:46:27.0236512Z     /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605:  Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> Microsoft.Build 17.8.5 -> Microsoft.Build.Framework (>= 17.8.5)  [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]
2024-04-20T01:46:27.0237107Z     /vmr/src/runtime/artifacts/source-build/self/src/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks.csproj : error NU1605:  Microsoft.NET.Sdk.WebAssembly.Pack.Tasks -> Microsoft.Build.Framework (>= 17.8.3) [/vmr/src/runtime/artifacts/source-build/self/src/Build.proj]

Updated the runtime patch.

[NikolaMilosavljevic]

Hmm, VMR sync error not seen locally - investigating.

[MichaelSimons]

May have to make the pr against internal - there could be conflicting runtime changes flowing in.

[NikolaMilosavljevic]

May have to make the pr against internal - there could be conflicting runtime changes flowing in.

That might be a better option. I'll create a PR against internal. I did update this PR as well, but I had to modify the approach to avoid merge conflicts in V.D.xml and V.props.

[ViktorHofer]

This is a product change in a release branch. Curious what's the process here. Don't you need an approval from the team that owns these components? cc @akoeplinger

[NikolaMilosavljevic]

Closing as this was merged with https://dev.azure.com/dnceng/internal/_git/dotnet-installer/pullrequest/39154