Conversation
Member
richlander
commented
Nov 2, 2020
richlander
commented
- We decided that a two line scheme is better.
- It is simply a simplification. It has no actual or intended legal meaning/change.
- Same as Standardize on new two-line license header runtime#38793
Ellerbach
approved these changes
Nov 2, 2020
Member
Ellerbach
left a comment
Ellerbach
left a comment
There was a problem hiding this comment.
I was now so used to the 3 lines :-) Great it's simplified!
Contributor
|
I guess the license header in each file has no legal impact anyway. Whoever uses the code must check the license details anyway. (If in doubt, not specifying a license would mean "no rights granted"). |
Member
|
LGTM, @richlander why do we need license header at all? Isn't root LICENSE file enough? |
joperezr
approved these changes
Nov 2, 2020
Member
joperezr
left a comment
joperezr
left a comment
There was a problem hiding this comment.
Thanks a bunch for doing this @richlander
richlander
added a commit
that referenced
this pull request
Nov 6, 2020
ZhangGaoxing
pushed a commit
to ZhangGaoxing/iot
that referenced
this pull request
Mar 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.