Skip to content

Added pin options, abstract class and I2C#130

Merged
joperezr merged 8 commits intodotnet:masterfrom
shaggygi:mcp23xxx-pin-additions
Jan 22, 2019
Merged

Added pin options, abstract class and I2C#130
joperezr merged 8 commits intodotnet:masterfrom
shaggygi:mcp23xxx-pin-additions

Conversation

@shaggygi
Copy link
Contributor

Created an abstract and separated for I2C and SPI.

Modified addressing approach to instantiate binding with device instead of being able to address multiple devices within Read/Write methods. This fits better with the connection settings.

Added controller pin options for reset and interrupt pins. Events are planned for future PR.

Updated samples and documentation.

See #88 for future details.

@shaggygi shaggygi mentioned this pull request Dec 31, 2018
4 tasks
@joshfree joshfree requested review from buyaa-n, krwq and tarekgh January 4, 2019 19:11
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @shaggygi!

@joperezr joperezr merged commit 93f2bd3 into dotnet:master Jan 22, 2019
@shaggygi shaggygi deleted the mcp23xxx-pin-additions branch January 22, 2019 19:05
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants