Conversation
Please move these two files under src/devices/Common/BitmapImage.cs and also change the namespace so that it is like: |
Also, can you please add the liscensing headers into these two files as well? |
These samples project should instead live under the binding you added in a samples folder. You can check all of our existing bindings for examples, but basically what we require for a binding is: a project under |
|
Hey @maloo, thanks for your contribution! I left some initial comments on the PR, in order to produce the right layout/structure we are looking for in a binding, would you mind either copying the structure of an existing binding or using the steps outlined here in order to create your binding project using our CLI template? That should help you get started without having to deal with the rest of our infrastructure 😉 |
|
Hey @maloo thanks for contributing, couple of comments (mostly naming and layout) other than that looks good! |
fixes: #170
cc: @krwq @joperezr