Pressure to altitude conversion fixed#2483
Merged
pgrawehr merged 5 commits intodotnet:mainfrom Mar 13, 2026
Merged
Conversation
dotnet-policy-service
bot
added
the
area-device-bindings
Results look really reasonable
krwq
reviewed
Mar 12, 2026
| double meters = ((Math.Pow(seaLevelPressure.Pascals / pressure.Pascals, 1 / 5.255) - 1) * airTemperature.Kelvins) / DefaultTemperatureGradient; | ||
| return Length.FromMeters(meters); | ||
| } | ||
| [Obsolete("Behavior is confusing. Use CalculateAltitude(Pressure, Pressure, Temperature) instead")] |
krwq
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2481
The formula had a typo, which resulted in values being off around 10%.
The change is breaking, because one overload was removed, as it technically doesn't make sense.
Microsoft Reviewers: Open in CodeFlow