Add initial Mcp23xxx binding#91
Merged
joperezr merged 5 commits intodotnet:masterfrom Dec 18, 2018
shaggygi:mcp23xxx
Merged
Conversation
4 tasks
joperezr
reviewed
Dec 11, 2018
joperezr
reviewed
Dec 11, 2018
joperezr
reviewed
Dec 11, 2018
joperezr
reviewed
Dec 11, 2018
joperezr
reviewed
Dec 11, 2018
joperezr
reviewed
Dec 18, 2018
Member
|
This looks great! Thanks for addressing the feedback and we'll take a look at perhaps making this an abstract base class and specific subclasses once we add the Gpio implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added initial Mcp23xxx binding. This includes the core binding, unit testing, and simple sample. This was another introductory PR exercise as it is my first binding from the beginning.
This only included the SPI interface. I just wanted to get this started since there are many parts. I will follow-up with I2C and bit-bang support for binding soon.
//cc @joperezr @joshfree again, please be gentle 😄