Skip to content

Conversation

@jonpryor
Copy link
Contributor

@jonpryor jonpryor commented Jan 9, 2025

Context: #1288

We're considering adding a check to CI if the build changes any files, and src/Java.Base-ref.cs is one of the primary instigators for such in-tree changes.

Flush the current output of Java.Base-ref.cs when building against JDK-11, which is the current JDK used on dotnet/java-interop CI.

Context: #1288

We're considering adding a check to CI if the build changes any files,
and `src/Java.Base-ref.cs` is one of the primary instigators for such
in-tree changes.

Flush the current output of `Java.Base-ref.cs` when building against
JDK-11, which is the current JDK used on dotnet/java-interop CI.
@jonpryor
Copy link
Contributor Author

jonpryor commented Jan 9, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jonpryor
Copy link
Contributor Author

jonpryor commented Jan 9, 2025

Superseded by PR #1291. Apparently, Java.Base-ref.cs was already built against JDK-17, so preferring JDK-17 means the file contents won't change! (Except maybe line endings?)

@jonpryor jonpryor closed this Jan 9, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants