Skip to content

[build] option to filter by JI_MAX_JDK on make prepare #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonpryor merged 2 commits into from
Dec 21, 2017
Merged

[build] option to filter by JI_MAX_JDK on make prepare #226

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
312b2c5
[build] option to filter by JI_MAX_JDK on make prepare
jonathanpeppers Dec 18, 2017
1c437a1
Add comment to elaborate on `$(_VERSION_SORT)`.
jonpryor Dec 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions build-tools/scripts/jdk.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
# $(OS): Optional; **uname**(1) value of the host operating system
# $(CONFIGURATION): Build configuration name, e.g. Debug or Release
# $(RUNTIME): `mono` executable for the host operating system
# $(JI_MAX_JDK):
# Maximum allowed JDK version, blank by default.
# `xamarin-android` will need to specify 8 here
#
# Outputs:
#
Expand All @@ -21,6 +24,19 @@
# Location of the Java native library that contains e.g. JNI_CreateJavaVM().

OS ?= $(shell uname)
JI_JAVAC_PATH = javac
JI_JAR_PATH = jar


# Filter on <= JI_MAX_JDK
ifneq ($(JI_MAX_JDK),)
_VERSION_MAX := | awk '$$1 <= $(JI_MAX_JDK)'
endif #JI_MAX_JDK

# Sort numerically on version numbers with `sort -n`, filtering on $(JI_MAX_JDK) if needed
# Replace each line so it starts with a number (sed 's/...'\1 &/), sort on the leading number, then remove the leading number.
# Grab the last path name printed.
_VERSION_SORT := sed 's/[^0-9]*\([0-9.]*\)/\1 &/' $(_VERSION_MAX) | sort -n | sed 's/^[0-9.]* //g' | tail -1

ifeq ($(OS),Darwin)

Expand Down Expand Up @@ -58,7 +74,9 @@ _LOCAL_JDK_HEADERS = LocalJDK/System/Library/Frameworks/JavaVM.fr
_APPLE_JDK6_URL = http://adcdownload.apple.com/Developer_Tools/java_for_os_x_2013005_developer_package/java_for_os_x_2013005_dp__11m4609.dmg

ifneq ($(_DARWIN_JDK_FALLBACK_DIRS),)
_DARWIN_JDK_ROOT := $(shell ls -dtr $(_DARWIN_JDK_FALLBACK_DIRS) | sort | tail -1)
_DARWIN_JDK_ROOT := $(shell ls -dtr $(_DARWIN_JDK_FALLBACK_DIRS) | $(_VERSION_SORT))
JI_JAVAC_PATH = $(_DARWIN_JDK_ROOT)/Contents/Home/bin/javac
JI_JAR_PATH = $(_DARWIN_JDK_ROOT)/Contents/Home/bin/jar
JI_JDK_INCLUDE_PATHS = \
$(_DARWIN_JDK_ROOT)/$(_DARWIN_JDK_JNI_INCLUDE_DIR) \
$(_DARWIN_JDK_ROOT)/$(_DARWIN_JDK_JNI_OS_INCLUDE_DIR)
Expand Down Expand Up @@ -108,7 +126,7 @@ _LINUX_JAVA_ROOT = $(JAVA_HOME)
endif # No default Java location, $JAVA_HOME check

ifeq ($(wildcard $(_DESKTOP_JAVA_INCLUDE_DIRS)),)
LATEST_JDK := $(shell ls -dtr $(_LINUX_JAVA_FALLBACK_DIRS) | sort | tail -1)
LATEST_JDK := $(shell ls -dtr $(_LINUX_JAVA_FALLBACK_DIRS) | $(_VERSION_SORT))
_DESKTOP_JAVA_INCLUDE_DIRS = $(LATEST_JDK)/$(_LINUX_JAVA_JNI_INCLUDE_DIR)
_LINUX_JAVA_ROOT = $(LATEST_JDK)
endif # No $JAVA_HOME, find the latest version
Expand All @@ -125,6 +143,9 @@ JI_JVM_PATH = $(_LINUX_JAVA_ROOT)/jre/lib/$(_LINUX_JAVA_ARCH_32)
endif # (2)
endif # (1)

JI_JAVAC_PATH = $(_LINUX_JAVA_ROOT)/bin/javac
JI_JAR_PATH = $(_LINUX_JAVA_ROOT)/bin/jar

endif # Linux

$(JI_JVM_PATH):
Expand All @@ -148,7 +169,7 @@ bin/Build$(CONFIGURATION)/JdkInfo.props: $(JI_JDK_INCLUDE_PATHS) $(JI_JVM_PATH)
echo ' </When>' >> "$@"
echo ' </Choose>' >> "$@"
echo ' <PropertyGroup>' >> "$@"
echo " <JavaCPath Condition=\" '\$$(JavaCPath)' == '' \">javac</JavaCPath>" >> "$@"
echo " <JarPath Condition=\" '\$$(JarPath)' == '' \">jar</JarPath>" >> "$@"
echo " <JavaCPath Condition=\" '\$$(JavaCPath)' == '' \">$(JI_JAVAC_PATH)</JavaCPath>" >> "$@"
echo " <JarPath Condition=\" '\$$(JarPath)' == '' \">$(JI_JAR_PATH)</JarPath>" >> "$@"
echo ' </PropertyGroup>' >> "$@"
echo '</Project>' >> "$@"